Skip to content

Blog page Tab Improvement.#1288

Merged
benjagm merged 5 commits intojson-schema-org:mainfrom
cbum-dev:issues/#1287
Jan 18, 2025
Merged

Blog page Tab Improvement.#1288
benjagm merged 5 commits intojson-schema-org:mainfrom
cbum-dev:issues/#1287

Conversation

@cbum-dev
Copy link
Contributor

What kind of change does this PR introduce?

Improved the blog category navigation section.
Previously it was scrolling up upon changing the tab but now its not doing so.

Issue Number:

Screenshots/videos:

Screencast.From.2025-01-10.22-33-50.mp4

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@cbum-dev cbum-dev requested a review from a team as a code owner January 10, 2025 17:05
@github-actions
Copy link

github-actions bot commented Jan 10, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 375a5de

@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4fe7488) to head (375a5de).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1288   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I click on category button which are within blog cards, I'm still scrolling back to up. Pls. fix that too.

@cbum-dev
Copy link
Contributor Author

When I click on category button which are within blog cards, I'm still scrolling back to up. Pls. fix that too.

Done.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update and Opinion categories as still scrolling to the top of the page.

@cbum-dev
Copy link
Contributor Author

Update and Opinion categories as still scrolling to the top of the page.

@benjagm I can't see this issue on my machine. Can you please recheck it?

Screencast.From.2025-01-18.20-15-59.mp4

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjagm benjagm merged commit 69c8c3c into json-schema-org:main Jan 18, 2025
9 checks passed
@github-actions
Copy link

Congratulations, @cbum-dev for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Clicking on blog category tab scrolling to top.

3 participants